HADOOP-17081. MetricsSystem doesn't start the sink adapters on restart#2089
Merged
steveloughran merged 3 commits intoapache:trunkfrom Jul 6, 2020
Merged
HADOOP-17081. MetricsSystem doesn't start the sink adapters on restart#2089steveloughran merged 3 commits intoapache:trunkfrom
steveloughran merged 3 commits intoapache:trunkfrom
Conversation
|
💔 -1 overall
This message was automatically generated. |
mmpataki
changed the title
mmpataki
force-pushed
the
HADOOP-17081
branch
2 times, most recently
from
d759021 to
eeed85b
Compare
What changed - The sink registration starts the adapter if it doesn't exists.
steveloughran
requested changes
Jul 3, 2020
| try { | ||
| ms.start(); | ||
| ms.register(sinkName, "", ts); | ||
| assertNotNull("an adapter should exist for each sink", ms.getSinkAdapter(sinkName)); |
Contributor
There was a problem hiding this comment.
we're generally still 80 chars wide, I'm afraid...put the actual probe on a new line.
nice to see some text for the assertion tnough -appreciated
Contributor
Author
There was a problem hiding this comment.
Fixed it, please review (added more info to the message)
steveloughran
requested changes
Jul 3, 2020
Contributor
steveloughran
left a comment
steveloughran
left a comment
There was a problem hiding this comment.
LGTM, +1 pending that checkstyle fixup. [Don't worry about yetus reporting javadoc issues on java 11 BTW]
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
+1 merged to trunk and about to pull into branch-3.3 |
asfgit
pushed a commit
that referenced
this pull request
Jul 6, 2020
#2089) Contributed by Madhusoodan P
asfgit
pushed a commit
that referenced
this pull request
Jul 6, 2020
#2089) Contributed by Madhusoodan P
Contributor
|
and 3.2 BTW, if you are looking at metrics, why not look at #2069 . That's not about publishing externally, but it is designed to enable apps to collect statistics in detail about an instance of an IO object (stream etc) for collation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed